maildev@lists.thunderbird.net

Thunderbird email developers

View all threads

New mach lint options for Thunderbird

RL
Rob Lemley
Wed, Apr 15, 2020 7:18 PM

There's a few new lint checks running on Taskcluster now on try-c-c and
comm-central.

In order to run those locally, you need to pass
--config-path=comm/tools/lint to mach lint:

Ex:
*$ ./mach lint --config-path=comm/tools/lint -l file-whitespace comm/mail

*New checks:
file-perm: checks for +x on files that don't need it
file-whitespace: look for extra whitespace
license: checks for a license header
lintpref: checks for duplicates between all-thunderbird.js and
StaticPrefList
mingw-cap:  filename capitalization issues
py-compat: python2/3 compatibility problems

And on try-c-c: (currently failing and need work)
shellcheck: look for common problems in shell scripts
codespell: look for common spelling errors

**

--
Rob Lemley
Thunderbird Build Engineer
rob@thunderbird.net - :rjl

There's a few new lint checks running on Taskcluster now on try-c-c and comm-central. In order to run those locally, you need to pass --config-path=comm/tools/lint to mach lint: Ex: *$ ./mach lint --config-path=comm/tools/lint -l file-whitespace comm/mail *New checks: file-perm: checks for +x on files that don't need it file-whitespace: look for extra whitespace license: checks for a license header lintpref: checks for duplicates between all-thunderbird.js and StaticPrefList mingw-cap:  filename capitalization issues py-compat: python2/3 compatibility problems And on try-c-c: (currently failing and need work) shellcheck: look for common problems in shell scripts codespell: look for common spelling errors ** -- Rob Lemley Thunderbird Build Engineer rob@thunderbird.net - :rjl
AC
Alessandro Castellani
Wed, Apr 15, 2020 7:21 PM

Let's add this to our DTN, this is super useful.

On 2020-04-15 12:18 p.m., Rob Lemley wrote:

There's a few new lint checks running on Taskcluster now on try-c-c
and comm-central.

In order to run those locally, you need to pass
--config-path=comm/tools/lint to mach lint:

Ex:
*$ ./mach lint --config-path=comm/tools/lint -l file-whitespace comm/mail

*New checks:
file-perm: checks for +x on files that don't need it
file-whitespace: look for extra whitespace
license: checks for a license header
lintpref: checks for duplicates between all-thunderbird.js and
StaticPrefList
mingw-cap:  filename capitalization issues
py-compat: python2/3 compatibility problems

And on try-c-c: (currently failing and need work)
shellcheck: look for common problems in shell scripts
codespell: look for common spelling errors

--
Rob Lemley
Thunderbird Build Engineer
rob@thunderbird.net  - :rjl


Maildev mailing list
Maildev@lists.thunderbird.net
http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net

--
Alessandro Castellani
Lead UX Architect
Thunderbird

Let's add this to our DTN, this is super useful. On 2020-04-15 12:18 p.m., Rob Lemley wrote: > There's a few new lint checks running on Taskcluster now on try-c-c > and comm-central. > > In order to run those locally, you need to pass > --config-path=comm/tools/lint to mach lint: > > Ex: > *$ ./mach lint --config-path=comm/tools/lint -l file-whitespace comm/mail > > *New checks: > file-perm: checks for +x on files that don't need it > file-whitespace: look for extra whitespace > license: checks for a license header > lintpref: checks for duplicates between all-thunderbird.js and > StaticPrefList > mingw-cap:  filename capitalization issues > py-compat: python2/3 compatibility problems > > And on try-c-c: (currently failing and need work) > shellcheck: look for common problems in shell scripts > codespell: look for common spelling errors > > -- > Rob Lemley > Thunderbird Build Engineer > rob@thunderbird.net - :rjl > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net -- *Alessandro Castellani* Lead UX Architect Thunderbird