There's been a couple of new linters added to comm-central builds in the past couple of weeks. If you're seeing these or other linting errors in your try builds, please take care of them before committing. The first is Python Black. If you modify any Python scripts include moz.build files you may see this one pop up. This one has an autofix feature, so you can fix any issues with: mach lint --config-path=comm/tools/lint -l black comm/path/to/script.py --fix The other is the license linter. This is to make sure Thunderbird is in compliance with the Mozilla Source Code License Policy[2]. Any new code checked into the repository needs to comply with the policy. There are copy-and-pastable templates available[3]. Let me know if you have any questions. -Rob [1] Python Black - https://black.readthedocs.io/en/stable/ [2] Mozilla source code License Policy - https://www.mozilla.org/en-US/MPL/license-policy/ [3] Mozilla License Header Templates - https://www.mozilla.org/en-US/MPL/headers/ -- *Rob Lemley* Thunderbird Release Engineer rob@thunderbird.net - :rjl -*- #thereisonlyxul -*-

I wondered if this was automatic or had to be manually run, thank you. On 11/20/20 9:01 PM, Rob Lemley wrote: > There's been a couple of new linters added to comm-central builds in > the past couple of weeks. If you're seeing these or other linting > errors in your try builds, please take care of them before committing. > > The first is Python Black. If you modify any Python scripts include > moz.build files you may see this one pop up. This one has an autofix > feature, so you can fix any issues with: > > mach lint --config-path=comm/tools/lint -l black > comm/path/to/script.py --fix > > The other is the license linter. This is to make sure Thunderbird is > in compliance with the Mozilla Source Code License Policy[2]. Any new > code checked into the repository needs to comply with the policy. > There are copy-and-pastable templates available[3]. > > Let me know if you have any questions. > > -Rob > > [1] Python Black - https://black.readthedocs.io/en/stable/ > [2] Mozilla source code License Policy - > https://www.mozilla.org/en-US/MPL/license-policy/ > [3] Mozilla License Header Templates - > https://www.mozilla.org/en-US/MPL/headers/ > > -- > *Rob Lemley* > Thunderbird Release Engineer > rob@thunderbird.net - :rjl > -*- #thereisonlyxul -*- > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net

They will run automatically on try-cc builds and on comm-central. The long term plan is to have them run when you submit review through Phabricator like you get on mozilla-central. On 11/23/20 7:41 AM, Lasana Murray wrote: > > I wondered if this was automatic or had to be manually run, thank you. > > On 11/20/20 9:01 PM, Rob Lemley wrote: >> There's been a couple of new linters added to comm-central builds in >> the past couple of weeks. If you're seeing these or other linting >> errors in your try builds, please take care of them before committing. >> >> The first is Python Black. If you modify any Python scripts include >> moz.build files you may see this one pop up. This one has an autofix >> feature, so you can fix any issues with: >> >> mach lint --config-path=comm/tools/lint -l black >> comm/path/to/script.py --fix >> >> The other is the license linter. This is to make sure Thunderbird is >> in compliance with the Mozilla Source Code License Policy[2]. Any new >> code checked into the repository needs to comply with the policy. >> There are copy-and-pastable templates available[3]. >> >> Let me know if you have any questions. >> >> -Rob >> >> [1] Python Black - https://black.readthedocs.io/en/stable/ >> [2] Mozilla source code License Policy - >> https://www.mozilla.org/en-US/MPL/license-policy/ >> [3] Mozilla License Header Templates - >> https://www.mozilla.org/en-US/MPL/headers/ >> >> -- >> *Rob Lemley* >> Thunderbird Release Engineer >> rob@thunderbird.net - :rjl >> -*- #thereisonlyxul -*- >> >> _______________________________________________ >> Maildev mailing list >> Maildev@lists.thunderbird.net >> http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net -- *Rob Lemley* Thunderbird Release Engineer rob@thunderbird.net - :rjl -*- #thereisonlyxul -*-

SVG files are now checked for a license comment as well. On 11/20/20 8:01 PM, Rob Lemley wrote: > There's been a couple of new linters added to comm-central builds in > the past couple of weeks. If you're seeing these or other linting > errors in your try builds, please take care of them before committing. > > The first is Python Black. If you modify any Python scripts include > moz.build files you may see this one pop up. This one has an autofix > feature, so you can fix any issues with: > > mach lint --config-path=comm/tools/lint -l black > comm/path/to/script.py --fix > > The other is the license linter. This is to make sure Thunderbird is > in compliance with the Mozilla Source Code License Policy[2]. Any new > code checked into the repository needs to comply with the policy. > There are copy-and-pastable templates available[3]. > > Let me know if you have any questions. > > -Rob > > [1] Python Black - https://black.readthedocs.io/en/stable/ > [2] Mozilla source code License Policy - > https://www.mozilla.org/en-US/MPL/license-policy/ > [3] Mozilla License Header Templates - > https://www.mozilla.org/en-US/MPL/headers/ > > -- > *Rob Lemley* > Thunderbird Release Engineer > rob@thunderbird.net - :rjl > -*- #thereisonlyxul -*- > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net -- *Rob Lemley* Thunderbird Release Engineer rob@thunderbird.net - :rjl -*- #thereisonlyxul -*-