Hi All, I made some changes on top of pjproject-1.10 version to port the same on 64bit windows platform. After changes i tested the same, It is working fine. May i request to you all, Please review the attached code changes and if possible provide your valuable inputs to me. If all goes well, Can we integrate the same changes in future releases? Thanks and Regards, Vishal Mahajan

On Thu, Sep 22, 2011 at 4:57 PM, Vishal Mahajan <vishal-mahajan@hotmail.com> wrote: > Hi All, > > I made some changes on top of pjproject-1.10 version to port the same on > 64bit windows platform. > > After changes i tested the same, It is working fine. > > May i request to you all, Please review the attached code changes and if > possible provide your valuable inputs to me. > > If all goes well, Can we integrate the same changes in future releases? > Yes why not. But where's the code? :) Benny

Resending the with attachment. Regards, Vishal From: vishal-mahajan@hotmail.com To: pjsip@lists.pjsip.org; vishal-mahajan@hotmail.com Subject: Regarding 64bit porting of PJSIP on windows Date: Thu, 22 Sep 2011 09:57:48 +0000 Hi All, I made some changes on top of pjproject-1.10 version to port the same on 64bit windows platform. After changes i tested the same, It is working fine. May i request to you all, Please review the attached code changes and if possible provide your valuable inputs to me. If all goes well, Can we integrate the same changes in future releases? Thanks and Regards, Vishal Mahajan

Hi Vishal, I have not tried compiling pjproject on Win64 yet, but one day I certainly will. The only significant change I can see in the docx, is the first one regarding the pool buffer, although I do not understand it. The others are meaningless, I think, since on Win64: sizeof(__int64) = sizeof(long) = sizeof(long long) = sizeof(void*) = 8 Cheers, - Vali Dne 23.9.2011 8:12, Vishal Mahajan napsal(a): > Resending the with attachment. > > Regards, > Vishal > > ------------------------------------------------------------------------ > From: vishal-mahajan@hotmail.com > To: pjsip@lists.pjsip.org; vishal-mahajan@hotmail.com > Subject: Regarding 64bit porting of PJSIP on windows > Date: Thu, 22 Sep 2011 09:57:48 +0000 > > Hi All, > > I made some changes on top of pjproject-1.10 version to port the same on > 64bit windows platform. > > After changes i tested the same, It is working fine. > > May i request to you all, Please review the attached code changes and if > possible provide your valuable inputs to me. > > If all goes well, Can we integrate the same changes in future releases? > > Thanks and Regards, > Vishal Mahajan > > > > > > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

On Fri, Sep 23, 2011 at 4:28 PM, Tomáš Valenta <vali@kamarad.cz> wrote: > Hi Vishal, > > I have not tried compiling pjproject on Win64 yet, but one day I certainly > will. > > The only significant change I can see in the docx, is the first one > regarding the pool buffer, although I do not understand it. > > The others are meaningless, I think, since on Win64: > sizeof(__int64) = sizeof(long) = sizeof(long long) = sizeof(void*) = 8 > Unfortunately that's not correct for Win64. According to: http://technet.microsoft.com/en-us/library/bb496995.aspx, sizeof(long) is just 4. So maybe it requires that much changes indeed, although I think the patch still has few issues with it. Benny

Sorry for mystification and thank you for clarifying. Obviously the article I read about Visual C++ in the past was wrong. Since Visual Studio since 2005, there is intptr_t, but I do not know how it is with older VS's. Anyway, good luck with porting on Win64. Vali Dne 23.9.2011 13:46, Benny Prijono napsal(a): > On Fri, Sep 23, 2011 at 4:28 PM, Tomáš Valenta<vali@kamarad.cz> wrote: >> Hi Vishal, >> >> I have not tried compiling pjproject on Win64 yet, but one day I certainly >> will. >> >> The only significant change I can see in the docx, is the first one >> regarding the pool buffer, although I do not understand it. >> >> The others are meaningless, I think, since on Win64: >> sizeof(__int64) = sizeof(long) = sizeof(long long) = sizeof(void*) = 8 >> > > Unfortunately that's not correct for Win64. According to: > http://technet.microsoft.com/en-us/library/bb496995.aspx, sizeof(long) > is just 4. So maybe it requires that much changes indeed, although I > think the patch still has few issues with it. > > Benny > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Benny, I have run a sample program to identify the size of following on win64, Please see the below output. sizeof long is (4) sizeof long pointer is (8) sizeof long long is (8) sizeof long long pointer is (8) sizeof __int64 (8) sizeof __int64 pointer (8) sizeof void* is (8) Please let know if i am missing something Regards, Vishal Mahajan > Date: Fri, 23 Sep 2011 18:46:20 +0700 > From: bennylp@teluu.com > To: pjsip@lists.pjsip.org > Subject: Re: [pjsip] Regarding 64bit porting of PJSIP on windows > > On Fri, Sep 23, 2011 at 4:28 PM, Tomáš Valenta <vali@kamarad.cz> wrote: > > Hi Vishal, > > > > I have not tried compiling pjproject on Win64 yet, but one day I certainly > > will. > > > > The only significant change I can see in the docx, is the first one > > regarding the pool buffer, although I do not understand it. > > > > The others are meaningless, I think, since on Win64: > > sizeof(__int64) = sizeof(long) = sizeof(long long) = sizeof(void*) = 8 > > > > Unfortunately that's not correct for Win64. According to: > http://technet.microsoft.com/en-us/library/bb496995.aspx, sizeof(long) > is just 4. So maybe it requires that much changes indeed, although I > think the patch still has few issues with it. > > Benny > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org