Empathy List Archives

PM

Paul Morris

Tue, Feb 11, 2020 5:48 PM

|This is a public service announcement.
|

|A patch for "Remove MOZ_CALENDAR build config flag" should land soon:
https://bugzilla.mozilla.org/show_bug.cgi?id=1612190|

|When it lands developers will need to remove the following line from
their mozconfig files to successfully build Thunderbird:
|

|ac_add_options --enable-calendar|

|I will plan to send a follow-up email to announce when it has landed,
but you may want to cc yourself on the bug for good measure.
|

|-Paul
|

|This is a public service announcement. | |A patch for "Remove MOZ_CALENDAR build config flag" should land soon: https://bugzilla.mozilla.org/show_bug.cgi?id=1612190| |When it lands developers will need to remove the following line from their mozconfig files to successfully build Thunderbird: | |ac_add_options --enable-calendar| |I will plan to send a follow-up email to announce when it has landed, but you may want to cc yourself on the bug for good measure. | |-Paul |

BB

Ben Bucksch

Thu, Feb 13, 2020 3:06 AM

On 11.02.20 18:48, Paul Morris wrote:

|||https://bugzilla.mozilla.org/show_bug.cgi?id=1612190|

|When it lands developers will need to remove the following line from
their mozconfig files to successfully build Thunderbird:
|

|ac_add_options --enable-calendar|

FWIW, removing this flag this will break the build for Linux distros
that have this flag set. If you want to be nice, you can make another
followup patch, where you re-introduce the build flag, but it does
nothing, just outputs a warning that the flag should be removed from
mozconfig.

Debian and Gentoo use "|ac_add_options --enable-calendar" |and will
break, probably others as well.

https://packages.debian.org/buster/thunderbird ->
http://deb.debian.org/debian/pool/main/t/thunderbird/thunderbird_68.4.1-1~deb10u1.debian.tar.xz

https://forums.gentoo.org/viewtopic-t-1086936-start-0.html

On 11.02.20 18:48, Paul Morris wrote: > |||https://bugzilla.mozilla.org/show_bug.cgi?id=1612190| > > |When it lands developers will need to remove the following line from > their mozconfig files to successfully build Thunderbird: > | > > |ac_add_options --enable-calendar| > FWIW, removing this flag this will break the build for Linux distros that have this flag set. If you want to be nice, you can make another followup patch, where you re-introduce the build flag, but it does nothing, just outputs a warning that the flag should be removed from mozconfig. Debian and Gentoo use "|ac_add_options --enable-calendar" |and will break, probably others as well. https://packages.debian.org/buster/thunderbird -> http://deb.debian.org/debian/pool/main/t/thunderbird/thunderbird_68.4.1-1~deb10u1.debian.tar.xz https://forums.gentoo.org/viewtopic-t-1086936-start-0.html

MH

Matt Harris

Thu, Feb 13, 2020 11:07 AM

On 13-Feb-20 1:36 PM, Ben Bucksch wrote:

On 11.02.20 18:48, Paul Morris wrote:

|||https://bugzilla.mozilla.org/show_bug.cgi?id=1612190|

|When it lands developers will need to remove the following line from
their mozconfig files to successfully build Thunderbird:
|

|ac_add_options --enable-calendar|

FWIW, removing this flag this will break the build for Linux distros
that have this flag set. If you want to be nice, you can make another
followup patch, where you re-introduce the build flag, but it does
nothing, just outputs a warning that the flag should be removed from
mozconfig.

Perhaps it will flag the fact that there is no calendar and to remove it
from the Repos. Many still distribute Thunderbird with a separate
lightning, hence the complaints from the Linux world after ever update
that there is not current version up on ATN. This will be a test that
there have been changes. Perhaps a broken build will help get a good
outcome for their users from the update.

On 13-Feb-20 1:36 PM, Ben Bucksch wrote: > On 11.02.20 18:48, Paul Morris wrote: >> |||https://bugzilla.mozilla.org/show_bug.cgi?id=1612190| >> >> |When it lands developers will need to remove the following line from >> their mozconfig files to successfully build Thunderbird: >> | >> >> |ac_add_options --enable-calendar| >> > > FWIW, removing this flag this will break the build for Linux distros > that have this flag set. If you want to be nice, you can make another > followup patch, where you re-introduce the build flag, but it does > nothing, just outputs a warning that the flag should be removed from > mozconfig. > Perhaps it will flag the fact that there is no calendar and to remove it from the Repos. Many still distribute Thunderbird with a separate lightning, hence the complaints from the Linux world after ever update that there is not current version up on ATN. This will be a test that there have been changes. Perhaps a broken build will help get a good outcome for their users from the update.

PM

Paul Morris

Thu, Feb 13, 2020 1:14 PM

The patch to remove the MOZ_CALENDAR build config flag has now landed on
c-c.

Given Ben's point about Linux distros, we have made it a no-op to have
this option set, to avoid breaking any builds.

I'd still recommend removing the following line from your mozconfig file
if you are building from c-c:

|ac_add_options --enable-calendar|

-Paul

--
Paul Morris
Thunderbird.net

The patch to remove the MOZ_CALENDAR build config flag has now landed on c-c. Given Ben's point about Linux distros, we have made it a no-op to have this option set, to avoid breaking any builds. I'd still recommend removing the following line from your mozconfig file if you are building from c-c: |ac_add_options --enable-calendar| -Paul -- Paul Morris Thunderbird.net

BB

Ben Bucksch

Fri, Feb 14, 2020 3:19 PM

On 13.02.20 12:07, Matt Harris wrote:

On 13-Feb-20 1:36 PM, Ben Bucksch wrote:

On 11.02.20 18:48, Paul Morris wrote:

|||https://bugzilla.mozilla.org/show_bug.cgi?id=1612190|

|When it lands developers will need to remove the following line
from their mozconfig files to successfully build Thunderbird:
|

|ac_add_options --enable-calendar|

|Update to this: The latest patch that eventually landed accepts both.
Whether you have this flag set in your mozconfig or not, Thunderbird
will build and run in both cases, and it will always build calendar.|
||

FWIW, removing this flag this will break the build for Linux distros
that have this flag set. If you want to be nice, you can make another
followup patch, where you re-introduce the build flag, but it does
nothing, just outputs a warning that the flag should be removed from
mozconfig.

Perhaps it will flag the fact that there is no calendar and to remove
it from the Repos. Many still distribute Thunderbird with a separate
lightning, hence the complaints from the Linux world after ever update
that there is not current version up on ATN. This will be a test that
there have been changes. Perhaps a broken build will help get a good
outcome for their users from the update.

I'd rather not break them, but inform them with their respective bug
trackers that they should remove the flag and - if applicable - remove
their Lightning addon packages.

Matt, or if anybody else is affected by this, it would be nice to file
bug reports, for each the large distros: Debian, Ubuntu, Fedora, etc..

Ben

On 13.02.20 12:07, Matt Harris wrote: > On 13-Feb-20 1:36 PM, Ben Bucksch wrote: >> On 11.02.20 18:48, Paul Morris wrote: >>> |||https://bugzilla.mozilla.org/show_bug.cgi?id=1612190| >>> >>> |When it lands developers will need to remove the following line >>> from their mozconfig files to successfully build Thunderbird: >>> | >>> >>> |ac_add_options --enable-calendar| >>> |Update to this: The latest patch that eventually landed accepts both. Whether you have this flag set in your mozconfig or not, Thunderbird will build and run in both cases, and it will always build calendar.| || >> >> >> FWIW, removing this flag this will break the build for Linux distros >> that have this flag set. If you want to be nice, you can make another >> followup patch, where you re-introduce the build flag, but it does >> nothing, just outputs a warning that the flag should be removed from >> mozconfig. >> > Perhaps it will flag the fact that there is no calendar and to remove > it from the Repos. Many still distribute Thunderbird with a separate > lightning, hence the complaints from the Linux world after ever update > that there is not current version up on ATN. This will be a test that > there have been changes. Perhaps a broken build will help get a good > outcome for their users from the update. I'd rather not break them, but inform them with their respective bug trackers that they should remove the flag and - if applicable - remove their Lightning addon packages. Matt, or if anybody else is affected by this, it would be nice to file bug reports, for each the large distros: Debian, Ubuntu, Fedora, etc.. Ben

BB

Ben Bucksch

Fri, Feb 14, 2020 3:20 PM

On 14.02.20 16:19, Ben Bucksch wrote:

|Update to this: The latest patch that eventually landed accepts both.
Whether you have this flag set in your mozconfig or not, Thunderbird
will build and run in both cases, and it will always build calendar.|
||

To clarify: We simply ignore the flag for now.

But it's still deprecated, and you should remove it from your mozconfig
as soon as you read this. It will eventually be removed and then break
your build.

On 14.02.20 16:19, Ben Bucksch wrote: > > |Update to this: The latest patch that eventually landed accepts both. > Whether you have this flag set in your mozconfig or not, Thunderbird > will build and run in both cases, and it will always build calendar.| > || To clarify: We simply ignore the flag for now. But it's still deprecated, and you should remove it from your mozconfig as soon as you read this. It will eventually be removed and then break your build.

maildev@lists.thunderbird.net

Removal of MOZ_CALENDAR build config flag