maildev@lists.thunderbird.net

Thunderbird email developers

View all threads

Fwd: Window objects will no longer have a QueryInterface method in JS

PK
Philipp Kewisch
Wed, Jul 24, 2019 8:26 PM

This sounds like something we should check if it affects Thunderbird.

Philipp

-------- Forwarded Message --------
Subject: Window objects will no longer have a QueryInterface method in JS
Date: Wed, 24 Jul 2019 15:44:33 -0400
From: Boris Zbarsky bzbarsky@mit.edu
To: firefox-dev firefox-dev@mozilla.org

At this point, the only Web IDL objects with (chrome-only)
QueryInterface methods exposed to JS callers are Window and Element
instances.

In bug 1568585 [1] I plan to remove the QueryInterface JS method from
Window. I've ensured that a try run with a MOZ_CRASH when QueryInterface
is called on a Window from JS is green, so assuming we have test
coverage of all the relevant callsites there shouldn't be any problems.
But I figured I should give people a heads-up so they don't add new
callsites.

-Boris

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1568585


firefox-dev mailing list
firefox-dev@mozilla.org
https://mail.mozilla.org/listinfo/firefox-dev

This sounds like something we should check if it affects Thunderbird. Philipp -------- Forwarded Message -------- Subject: Window objects will no longer have a QueryInterface method in JS Date: Wed, 24 Jul 2019 15:44:33 -0400 From: Boris Zbarsky <bzbarsky@mit.edu> To: firefox-dev <firefox-dev@mozilla.org> At this point, the only Web IDL objects with (chrome-only) QueryInterface methods exposed to JS callers are Window and Element instances. In bug 1568585 [1] I plan to remove the QueryInterface JS method from Window. I've ensured that a try run with a MOZ_CRASH when QueryInterface is called on a Window from JS is green, so assuming we have test coverage of all the relevant callsites there shouldn't be any problems. But I figured I should give people a heads-up so they don't add new callsites. -Boris [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1568585 _______________________________________________ firefox-dev mailing list firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/firefox-dev
JK
Jörg Knobloch
Thu, Jul 25, 2019 7:57 PM

On 24 Jul 2019 22:26, Philipp Kewisch wrote:

This sounds like something we should check if it affects Thunderbird.

Thanks, we're already actively working on the issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=1568420

On 24 Jul 2019 22:26, Philipp Kewisch wrote: > This sounds like something we should check if it affects Thunderbird. Thanks, we're already actively working on the issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1568420