maildev@lists.thunderbird.net

Thunderbird email developers

View all threads

Simple tasks for students

PK
Philipp Kewisch
Wed, Aug 2, 2017 11:47 AM

On 8/1/17 10:37 PM, R Kent James via Maildev wrote:

One issue I have seen consistently as a barrier to progress within
Mozilla is ongoing threats that such-and-such code is going to be
obsolete Real Soon Now, so we stop trying to fix issues with it or
improve it. A great example is a freeze many years ago on new XUL
features, that was mostly done to reject a patch that Thunderbird
wanted that would have supported multiple lines in trees. XUL is still
with us, with no active efforts ongoing to change that. Now this TB:NG
discussion is threatening to prematurely freeze improvements in all of
Thunderbird. Let's be careful before we stop doing improvements in
existing code based on unresolved discussions about a possible future.

Yes, you are right about this. I was not saying we should be stopping
all improvements, and am not against doing linting. I love clean code.
If there is a specific group (like yours) that can work on an issue like
this it is great and should be done. If we have a new contributor that
can choose between fixing a bug and some linting rules, I'd say rather
fix the bug (no matter if it leads towards tb:ng or not).

Concerning the general proposal to start doing linting of existing
Thunderbird mail/ and mailnews/ code, I think we have had enough
discussions now to say that there is a rough consensus to support a
volunteer team doing this. Remaining details can be discussed in bugs
that are filed as part of this.

I agree.

Philipp

On 8/1/17 10:37 PM, R Kent James via Maildev wrote: > One issue I have seen consistently as a barrier to progress within > Mozilla is ongoing threats that such-and-such code is going to be > obsolete Real Soon Now, so we stop trying to fix issues with it or > improve it. A great example is a freeze many years ago on new XUL > features, that was mostly done to reject a patch that Thunderbird > wanted that would have supported multiple lines in trees. XUL is still > with us, with no active efforts ongoing to change that. Now this TB:NG > discussion is threatening to prematurely freeze improvements in all of > Thunderbird. Let's be careful before we stop doing improvements in > existing code based on unresolved discussions about a possible future. Yes, you are right about this. I was not saying we should be stopping all improvements, and am not against doing linting. I love clean code. If there is a specific group (like yours) that can work on an issue like this it is great and should be done. If we have a new contributor that can choose between fixing a bug and some linting rules, I'd say rather fix the bug (no matter if it leads towards tb:ng or not). > > Concerning the general proposal to start doing linting of existing > Thunderbird mail/ and mailnews/ code, I think we have had enough > discussions now to say that there is a rough consensus to support a > volunteer team doing this. Remaining details can be discussed in bugs > that are filed as part of this. I agree. Philipp