Javascript in comm-central is now fully linted
After a months-long effort, today I enabled the javascript linter in the
last remaining unlinted directory. All javascript code in comm-central
is now checked for errors at every check-in.
Linting enables us to quickly find some types of coding mistakes, and to
have much more consistent formatting of javascript, which in turn helps
you to find the code you're looking for more quickly.
If you are working on javascript code in comm-central, I recommend
installing an ESLint plug-in to your editor. For Sublime Text, I am
using SublimeLinter-eslint. Other suggestions are welcome here.
I want to thank aceman for his work reviewing my patches, some of which
were tens of thousands of lines long. How he did this without going
crazy is beyond me. Also thanks to the others who chipped in with
reviews, and to the chat team who took my starting patch and ran with it.
Happy nicely-formatted coding!
GL
Great work Geoff, and many thanks to others involved! Very nice to see
it finally completed.
If you want to run the linter in console, the mach command is lint, like
./mach lint comm/mail/base/content/mailCore.js
-Magnus
On 20-05-2019 12:03, Geoff Lankow wrote:
After a months-long effort, today I enabled the javascript linter in
the last remaining unlinted directory. All javascript code in
comm-central is now checked for errors at every check-in.
Linting enables us to quickly find some types of coding mistakes, and
to have much more consistent formatting of javascript, which in turn
helps you to find the code you're looking for more quickly.
If you are working on javascript code in comm-central, I recommend
installing an ESLint plug-in to your editor. For Sublime Text, I am
using SublimeLinter-eslint. Other suggestions are welcome here.
I want to thank aceman for his work reviewing my patches, some of
which were tens of thousands of lines long. How he did this without
going crazy is beyond me. Also thanks to the others who chipped in
with reviews, and to the chat team who took my starting patch and ran
with it.
Happy nicely-formatted coding!
GL
Maildev mailing list
Maildev@lists.thunderbird.net
http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net
Amazing work guys!
Thank you so much
On 2019-05-20 2:09 a.m., Magnus Melin wrote:
Great work Geoff, and many thanks to others involved! Very nice to see
it finally completed.
If you want to run the linter in console, the mach command is lint, like
./mach lint comm/mail/base/content/mailCore.js
-Magnus
On 20-05-2019 12:03, Geoff Lankow wrote:
After a months-long effort, today I enabled the javascript linter in
the last remaining unlinted directory. All javascript code in
comm-central is now checked for errors at every check-in.
Linting enables us to quickly find some types of coding mistakes, and
to have much more consistent formatting of javascript, which in turn
helps you to find the code you're looking for more quickly.
If you are working on javascript code in comm-central, I recommend
installing an ESLint plug-in to your editor. For Sublime Text, I am
using SublimeLinter-eslint. Other suggestions are welcome here.
I want to thank aceman for his work reviewing my patches, some of
which were tens of thousands of lines long. How he did this without
going crazy is beyond me. Also thanks to the others who chipped in
with reviews, and to the chat team who took my starting patch and ran
with it.
Happy nicely-formatted coding!
GL
Maildev mailing list
Maildev@lists.thunderbird.net
http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net
--
Alessandro Castellani
Lead UX Architect
Thunderbird
Yesss! So good! A real improvement that makes it much nicer to work
with the JS code.
I've had good experience with VS Code and the "ESLint" plugin (the one
maintained by Dirk Baeumer).
The console command also has a "--fix" option that will attempt to fix
problems automatically:
./mach lint comm/mail/base/content/mailCore.js --fix
-Paul
On 2019/05/20 18:03, Geoff Lankow wrote:
After a months-long effort, today I enabled the javascript linter in
the last remaining unlinted directory. All javascript code in
comm-central is now checked for errors at every check-in.
Linting enables us to quickly find some types of coding mistakes, and
to have much more consistent formatting of javascript, which in turn
helps you to find the code you're looking for more quickly.
If you are working on javascript code in comm-central, I recommend
installing an ESLint plug-in to your editor. For Sublime Text, I am
using SublimeLinter-eslint. Other suggestions are welcome here.
I want to thank aceman for his work reviewing my patches, some of
which were tens of thousands of lines long. How he did this without
going crazy is beyond me. Also thanks to the others who chipped in
with reviews, and to the chat team who took my starting patch and ran
with it.
Happy nicely-formatted coding!
GL
My hat off to Geoff and aceman, and numerous others who made it possible
to do this (!)
Thank you all.
Chiaki