discuss@lists.openscad.org

OpenSCAD general discussion Mailing-list

View all threads

Warning Grammar

AR
Algot Runeman
Thu, Jan 30, 2020 2:07 PM

While looking at some sample code from a recent email, I got the
following Console message:

WARNING: argument center supplied more then once, in file algot, line 16

Although it has NO impact on the validity of the warning, the word
"then" should be "than".

(Former teacher cannot stop offering edit suggestions!)

OpenSCAD version 19.05

While looking at some sample code from a recent email, I got the following Console message: WARNING: argument center supplied more then once, in file algot, line 16 Although it has NO impact on the validity of the warning, the word "then" should be "than". (Former teacher cannot stop offering edit suggestions!) OpenSCAD version 19.05
JB
Jordan Brown
Thu, Jan 30, 2020 9:56 PM

On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote:

(Former teacher cannot stop offering edit suggestions!)

+1!

On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote: > > (Former teacher cannot stop offering edit suggestions!) > > +1!
T
tjhowse
Fri, Jan 31, 2020 5:15 AM

Is there an easier way to get onto the contributors list for a FOSS project
than a minor grammatical fix?

PR raised here: https://github.com/openscad/openscad/pull/3202

On Fri, 31 Jan 2020 at 07:56, Jordan Brown openscad@jordan.maileater.net
wrote:

On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote:

(Former teacher cannot stop offering edit suggestions!)

+1!


OpenSCAD mailing list
Discuss@lists.openscad.org
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

Is there an easier way to get onto the contributors list for a FOSS project than a minor grammatical fix? PR raised here: https://github.com/openscad/openscad/pull/3202 On Fri, 31 Jan 2020 at 07:56, Jordan Brown <openscad@jordan.maileater.net> wrote: > On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote: > > (Former teacher cannot stop offering edit suggestions!) > > > +1! > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >
T
tjhowse
Fri, Jan 31, 2020 11:36 AM

Fixed: https://github.com/openscad/openscad/pull/3202

Thanks Marius!

On Fri, 31 Jan 2020 at 15:15, tjhowse tjhowse@gmail.com wrote:

Is there an easier way to get onto the contributors list for a FOSS
project than a minor grammatical fix?

PR raised here: https://github.com/openscad/openscad/pull/3202

On Fri, 31 Jan 2020 at 07:56, Jordan Brown openscad@jordan.maileater.net
wrote:

On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote:

(Former teacher cannot stop offering edit suggestions!)

+1!


OpenSCAD mailing list
Discuss@lists.openscad.org
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

Fixed: https://github.com/openscad/openscad/pull/3202 Thanks Marius! On Fri, 31 Jan 2020 at 15:15, tjhowse <tjhowse@gmail.com> wrote: > Is there an easier way to get onto the contributors list for a FOSS > project than a minor grammatical fix? > > PR raised here: https://github.com/openscad/openscad/pull/3202 > > On Fri, 31 Jan 2020 at 07:56, Jordan Brown <openscad@jordan.maileater.net> > wrote: > >> On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote: >> >> (Former teacher cannot stop offering edit suggestions!) >> >> >> +1! >> _______________________________________________ >> OpenSCAD mailing list >> Discuss@lists.openscad.org >> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >> >
AR
Algot Runeman
Fri, Jan 31, 2020 2:24 PM

Awesome!

FOSS fixing processes are marvelous. I didn't even need to know how to
do a pull request. Love this stuff. Thanks to all!

On 1/31/20 6:36 AM, tjhowse wrote:

Fixed: https://github.com/openscad/openscad/pull/3202

Thanks Marius!

On Fri, 31 Jan 2020 at 15:15, tjhowse <tjhowse@gmail.com
mailto:tjhowse@gmail.com> wrote:

 Is there an easier way to get onto the contributors list for a
 FOSS project than a minor grammatical fix?

 PR raised here: https://github.com/openscad/openscad/pull/3202

 On Fri, 31 Jan 2020 at 07:56, Jordan Brown
 <openscad@jordan.maileater.net
 <mailto:openscad@jordan.maileater.net>> wrote:

     On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote:
     (Former teacher cannot stop offering edit suggestions!)
     +1!
     _______________________________________________
     OpenSCAD mailing list
     Discuss@lists.openscad.org <mailto:Discuss@lists.openscad.org>
     http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

OpenSCAD mailing list
Discuss@lists.openscad.org
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

Awesome! FOSS fixing processes are marvelous. I didn't even need to know how to do a pull request. Love this stuff. Thanks to all! On 1/31/20 6:36 AM, tjhowse wrote: > Fixed: https://github.com/openscad/openscad/pull/3202 > > Thanks Marius! > > On Fri, 31 Jan 2020 at 15:15, tjhowse <tjhowse@gmail.com > <mailto:tjhowse@gmail.com>> wrote: > > Is there an easier way to get onto the contributors list for a > FOSS project than a minor grammatical fix? > > PR raised here: https://github.com/openscad/openscad/pull/3202 > > On Fri, 31 Jan 2020 at 07:56, Jordan Brown > <openscad@jordan.maileater.net > <mailto:openscad@jordan.maileater.net>> wrote: > > On 1/30/2020 6:07 AM, Algot Runeman via Discuss wrote: >> >> (Former teacher cannot stop offering edit suggestions!) >> >> > > +1! > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org <mailto:Discuss@lists.openscad.org> > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org > > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org