Hi maildev,

I would like to take module ownership of the account setup and account
creation dialogs.

I've been the inventor of the account setup dialog - in the sense that I
had the original idea of this entire feature and most of its facets -
and also the primary author of it. I've also led the feedback discussion
with the community that played into a number of product decisions of how
we do things (some of which led to decisions that were not my personal
favorite).

I've also been explicitly allowed to do reviews of that module in the
past, although I don't remember the exact details. In any case, I think
I understand the module very well, and more importantly the design
behind it. I also care a lot about it.

I would like to ask to be formally made module owner of the account
setup and account creation dialogs.

I'm asking for a vote by the Engineering Council, particilarly Jörg,
Magnus and Kent.

Thank you,

Ben

On 22/10/2017 23:25, Ben Bucksch wrote:

Typically, *contributors* are made peers or module owners through sending patches not by historical merit.

Are you claiming that I'm not a "contributor", even though I wrote most of the module?

You're a complicated case ;-) To use your words: "old retired firefighter" ;-)

In the last 2.5 years I've seen one patch from you, correct me if I'm wrong. Looks like your active time was before 2014 when I joined the project. Digging a little, I can confirm your authorship, for example here: https://hg.mozilla.org/comm-central/rev/2f6be5c00833#l2.22

As I said, I'm not opposed although the approach is a little unorthodox. Note that even with review authority, Alta88 has the right to escalate the dispute (which is not a review issue but more a question of which feature should be implemented) to the E/C.

You've just complained about the lack of reviews, in the previous post. I'm offering to do reviews. You ought to be happy.

Great, how about you clear your review queue, I can see one request from February 2017, and then stuff from 2014 and older. Once you're done there, move on to the NI queue :-(

Jörg.