There is a chance that this will eventually affect Thunderbird, when they get rid of the xpcom methods. Philipp Begin forwarded message: > From: Michael de Boer <mdeboer@mozilla.com> > Date: 19. April 2018 at 11:38:30 AM CEST > To: Firefox Dev <firefox-dev@mozilla.org> > Subject: PSA: RecentWindow.jsm is going away > > Hi all, > > Over at https://bugzilla.mozilla.org/show_bug.cgi?id=1034036 I’m about to land the following changes: > > RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm have been merged into one module called ‘BrowserWindowTracker.jsm’. > Meaning the first two mentioned modules will cease to exist. > The `getMostRecentBrowserWindow` method that was part of ye olde RecentWindow.jsm has been renamed to `getTopWindow`. > Browser order is now tracked entirely in the JS realm, which means we’ll be able to stop crossing the XPCOM boundary with nsIWindowMediator soon. > Meaning we’ll finally have proper window order information on Linux, > `getTopWindow` will switch to use this local info in a follow-up bug, where the Captive Portal tests will be fixed (the only blocker). > > I’m posting this here because RecentWindow.jsm is used quite frequently by system addons, Activity Stream being one of ‘em. Please update your codebase to not break on your next uplift to mozilla-central. > > Thanks! > > Mike. > > _______________________________________________ > firefox-dev mailing list > firefox-dev@mozilla.org > https://mail.mozilla.org/listinfo/firefox-dev

Is there idea which version of TB will be affected ? How about upcoming release of TB 60 with this? On 19.04.18 12:14, Philipp Kewisch wrote: > There is a chance that this will eventually affect Thunderbird, when > they get rid of the xpcom methods. > > Philipp > > > Begin forwarded message: > >> *From:* Michael de Boer <mdeboer@mozilla.com >> <mailto:mdeboer@mozilla.com>> >> *Date:* 19. April 2018 at 11:38:30 AM CEST >> *To:* Firefox Dev <firefox-dev@mozilla.org >> <mailto:firefox-dev@mozilla.org>> >> *Subject:* *PSA: RecentWindow.jsm is going away* >> >> Hi all, >> >> Over at https://bugzilla.mozilla.org/show_bug.cgi?id=1034036 I’m >> about to land the following changes: >> >> * RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm have >> been merged into one module called ‘BrowserWindowTracker.jsm’. >> o Meaning the first two mentioned modules will cease to exist. >> * The `getMostRecentBrowserWindow` method that was part of ye olde >> RecentWindow.jsm has been renamed to `getTopWindow`. >> * Browser order is now tracked entirely in the JS realm, which >> means we’ll be able to stop crossing the XPCOM boundary >> with nsIWindowMediator soon. >> o Meaning we’ll finally have proper window order information on >> Linux, >> o `getTopWindow` will switch to use this local info in a >> follow-up bug, where the Captive Portal tests will be fixed >> (the only blocker). >> >> >> I’m posting this here because RecentWindow.jsm is used quite >> frequently by system addons, Activity Stream being one of ‘em. Please >> update your codebase to not break on your next uplift to mozilla-central. >> >> Thanks! >> >> Mike. >> >> _______________________________________________ >> firefox-dev mailing list >> firefox-dev@mozilla.org <mailto:firefox-dev@mozilla.org> >> https://mail.mozilla.org/listinfo/firefox-dev > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net

No, likely no changes required for 1-2 cycles. Just a heads up. 60 is safe because it is in beta and they’d first have to do the actual removal and then have a good reason to uplift Philipp > On 19. Apr 2018, at 12:31 PM, neandr <neandr@gmx.de> wrote: > > Is there idea which version of TB will be affected ? How about upcoming release of TB 60 with this? >> On 19.04.18 12:14, Philipp Kewisch wrote: >> There is a chance that this will eventually affect Thunderbird, when they get rid of the xpcom methods. >> >> Philipp >> >> >> Begin forwarded message: >> >>> From: Michael de Boer <mdeboer@mozilla.com> >>> Date: 19. April 2018 at 11:38:30 AM CEST >>> To: Firefox Dev <firefox-dev@mozilla.org> >>> Subject: PSA: RecentWindow.jsm is going away >>> >>> Hi all, >>> >>> Over at https://bugzilla.mozilla.org/show_bug.cgi?id=1034036 I’m about to land the following changes: >>> >>> RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm have been merged into one module called ‘BrowserWindowTracker.jsm’. >>> Meaning the first two mentioned modules will cease to exist. >>> The `getMostRecentBrowserWindow` method that was part of ye olde RecentWindow.jsm has been renamed to `getTopWindow`. >>> Browser order is now tracked entirely in the JS realm, which means we’ll be able to stop crossing the XPCOM boundary with nsIWindowMediator soon. >>> Meaning we’ll finally have proper window order information on Linux, >>> `getTopWindow` will switch to use this local info in a follow-up bug, where the Captive Portal tests will be fixed (the only blocker). >>> >>> I’m posting this here because RecentWindow.jsm is used quite frequently by system addons, Activity Stream being one of ‘em. Please update your codebase to not break on your next uplift to mozilla-central. >>> >>> Thanks! >>> >>> Mike. >>> >>> _______________________________________________ >>> firefox-dev mailing list >>> firefox-dev@mozilla.org >>> https://mail.mozilla.org/listinfo/firefox-dev >> >> >> _______________________________________________ >> Maildev mailing list >> Maildev@lists.thunderbird.net >> http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net

     Components
         .classes['@mozilla.org/appshell/window-mediator;1']
         .getService(Components.interfaces.nsIWindowMediator)
         .getMostRecentWindow("mail:3pane")
         .document.getElementById("tabmail")
         .openTab("contentTab",
                  {contentPage: Sendlater3Backgrounding.notesUrl});

So I think you're saying that my code for displaying my add-on's release notes when the add-on's main window overlay is loaded is going to break? Here's what I do now: Components .classes['@mozilla.org/appshell/window-mediator;1'] .getService(Components.interfaces.nsIWindowMediator) .getMostRecentWindow("mail:3pane") .document.getElementById("tabmail") .openTab("contentTab", {contentPage: Sendlater3Backgrounding.notesUrl}); Any idea what I'll need to do instead?   jik On 4/19/18 6:14 AM, Philipp Kewisch wrote: > There is a chance that this will eventually affect Thunderbird, when > they get rid of the xpcom methods. > > Philipp > > > Begin forwarded message: > >> *From:* Michael de Boer <mdeboer@mozilla.com >> <mailto:mdeboer@mozilla.com>> >> *Date:* 19. April 2018 at 11:38:30 AM CEST >> *To:* Firefox Dev <firefox-dev@mozilla.org >> <mailto:firefox-dev@mozilla.org>> >> *Subject:* *PSA: RecentWindow.jsm is going away* >> >> Hi all, >> >> Over at https://bugzilla.mozilla.org/show_bug.cgi?id=1034036 I’m >> about to land the following changes: >> >> * RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm have >> been merged into one module called ‘BrowserWindowTracker.jsm’. >> o Meaning the first two mentioned modules will cease to exist. >> * The `getMostRecentBrowserWindow` method that was part of ye olde >> RecentWindow.jsm has been renamed to `getTopWindow`. >> * Browser order is now tracked entirely in the JS realm, which >> means we’ll be able to stop crossing the XPCOM boundary >> with nsIWindowMediator soon. >> o Meaning we’ll finally have proper window order information on >> Linux, >> o `getTopWindow` will switch to use this local info in a >> follow-up bug, where the Captive Portal tests will be fixed >> (the only blocker). >> >> >> I’m posting this here because RecentWindow.jsm is used quite >> frequently by system addons, Activity Stream being one of ‘em. Please >> update your codebase to not break on your next uplift to mozilla-central. >> >> Thanks! >> >> Mike. >> >> _______________________________________________ >> firefox-dev mailing list >> firefox-dev@mozilla.org <mailto:firefox-dev@mozilla.org> >> https://mail.mozilla.org/listinfo/firefox-dev > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net

Yes, this would be the code It is way too early to know how it may need to change, sorry if I am causing trouble. The code will continue to work, I’m just saying they may consider changing this since they mention that recent window is now completely in js. Logical conclusion would be they get rid of the xpcom class if it is all in js. Once that happens we’ll be sure to write it down somewhere. Philipp > On 19. Apr 2018, at 8:56 PM, Jonathan Kamens <jik@kamens.us> wrote: > > So I think you're saying that my code for displaying my add-on's release notes when the add-on's main window overlay is loaded is going to break? Here's what I do now: > Components > .classes['@mozilla.org/appshell/window-mediator;1'] > .getService(Components.interfaces.nsIWindowMediator) > .getMostRecentWindow("mail:3pane") > .document.getElementById("tabmail") > .openTab("contentTab", > {contentPage: Sendlater3Backgrounding.notesUrl}); > Any idea what I'll need to do instead? > > jik >> On 4/19/18 6:14 AM, Philipp Kewisch wrote: >> There is a chance that this will eventually affect Thunderbird, when they get rid of the xpcom methods. >> >> Philipp >> >> >> Begin forwarded message: >> >>> From: Michael de Boer <mdeboer@mozilla.com> >>> Date: 19. April 2018 at 11:38:30 AM CEST >>> To: Firefox Dev <firefox-dev@mozilla.org> >>> Subject: PSA: RecentWindow.jsm is going away >>> >>> Hi all, >>> >>> Over at https://bugzilla.mozilla.org/show_bug.cgi?id=1034036 I’m about to land the following changes: >>> >>> RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm have been merged into one module called ‘BrowserWindowTracker.jsm’. >>> Meaning the first two mentioned modules will cease to exist. >>> The `getMostRecentBrowserWindow` method that was part of ye olde RecentWindow.jsm has been renamed to `getTopWindow`. >>> Browser order is now tracked entirely in the JS realm, which means we’ll be able to stop crossing the XPCOM boundary with nsIWindowMediator soon. >>> Meaning we’ll finally have proper window order information on Linux, >>> `getTopWindow` will switch to use this local info in a follow-up bug, where the Captive Portal tests will be fixed (the only blocker). >>> >>> I’m posting this here because RecentWindow.jsm is used quite frequently by system addons, Activity Stream being one of ‘em. Please update your codebase to not break on your next uplift to mozilla-central. >>> >>> Thanks! >>> >>> Mike. >>> >>> _______________________________________________ >>> firefox-dev mailing list >>> firefox-dev@mozilla.org >>> https://mail.mozilla.org/listinfo/firefox-dev >> >> >> _______________________________________________ >> Maildev mailing list >> Maildev@lists.thunderbird.net >> http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net