changset 4555 issue

YT
Yosi Taguri
Sun, Jul 14, 2013 9:06 AM

I believe this changeset introduced a crash when calling

status = pjsua_call_make_call(acc_id, &pj_uri, 0, NULL, NULL, call_id);

with a NULL for msg_data.

from the changeset:

status = pjsip_dlg_create_uac( pjsip_ua_instance(),

724                                  &acc->cfg.id, &contact,

725                                  dest_uri,

726                                  (msg_data->target_uri.slen?

727                                    &msg_data->target_uri: dest_uri),

728                                  &dlg);

line 726 should check for NULL before accesing the target_uri

--

Yosi Taguri | Co-Founder | Labgoo | iPhone: http://ahhhpah.com | twitter:
http://twitter.com/yosit | Mobile: +972-54-4816020 | Google Voice US
Mobile: +1 (415) 935-1126 | Email: yosi@taguri.com

Confidential

I believe this changeset introduced a crash when calling status = pjsua_call_make_call(acc_id, &pj_uri, 0, NULL, NULL, call_id); with a NULL for msg_data. from the changeset: status = pjsip_dlg_create_uac( pjsip_ua_instance(), 724 &acc->cfg.id, &contact, 725 dest_uri, 726 (msg_data->target_uri.slen? 727 &msg_data->target_uri: dest_uri), 728 &dlg); line 726 should check for NULL before accesing the target_uri -- -- Yosi Taguri | Co-Founder | Labgoo | iPhone: http://ahhhpah.com | twitter: http://twitter.com/yosit | Mobile: +972-54-4816020 | Google Voice US Mobile: +1 (415) 935-1126 | Email: yosi@taguri.com *Confidential*
M
Ming
Mon, Jul 15, 2013 1:30 AM

Hi Yosi,

Thanks for pointing it out. We just fixed this in r4561.

Regards,
Ming

On Sun, Jul 14, 2013 at 5:06 PM, Yosi Taguri yosi@taguri.com wrote:

I believe this changeset introduced a crash when calling

 status = pjsua_call_make_call(acc_id, &pj_uri, 0, NULL, NULL,

call_id);

with a NULL for msg_data.

from the changeset:

status = pjsip_dlg_create_uac( pjsip_ua_instance(),

724                                  &acc->cfg.id, &contact,

725                                  dest_uri,

726                                  (msg_data->target_uri.slen?

727                                    &msg_data->target_uri: dest_uri),

728                                  &dlg);

line 726 should check for NULL before accesing the target_uri

--

Yosi Taguri | Co-Founder | Labgoo | iPhone: http://ahhhpah.com | twitter:
http://twitter.com/yosit | Mobile: +972-54-4816020 | Google Voice US
Mobile: +1 (415) 935-1126 | Email: yosi@taguri.com

Confidential


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Yosi, Thanks for pointing it out. We just fixed this in r4561. Regards, Ming On Sun, Jul 14, 2013 at 5:06 PM, Yosi Taguri <yosi@taguri.com> wrote: > I believe this changeset introduced a crash when calling > > status = pjsua_call_make_call(acc_id, &pj_uri, 0, NULL, NULL, > call_id); > > with a NULL for msg_data. > > from the changeset: > > status = pjsip_dlg_create_uac( pjsip_ua_instance(), > > 724 &acc->cfg.id, &contact, > > 725 dest_uri, > > 726 (msg_data->target_uri.slen? > > 727 &msg_data->target_uri: dest_uri), > > 728 &dlg); > > > line 726 should check for NULL before accesing the target_uri > > -- > -- > Yosi Taguri | Co-Founder | Labgoo | iPhone: http://ahhhpah.com | twitter: > http://twitter.com/yosit | Mobile: +972-54-4816020 | Google Voice US > Mobile: +1 (415) 935-1126 | Email: yosi@taguri.com > > *Confidential* > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >