Segfault when calling pjmedia_transport_srtp_create() with pjmedia_srtp_setting * set to NULL

RK
Ruud Klaver
Tue, Dec 2, 2008 3:25 PM

Hi,

According to the documentation it should be possible to call
pjmedia_transport_srtp_create() with the "opt" argument set to NULL,
it should just use the default SRTP settings. However, this pointer is
referenced anyway in the code at line 386 (of transport_srtp.c):

srtp->peer_use = opt->use;

This should probably directly reference the default "use" parameter if
opt == NULL.

Ruud Klaver
AG Projects

Hi, According to the documentation it should be possible to call pjmedia_transport_srtp_create() with the "opt" argument set to NULL, it should just use the default SRTP settings. However, this pointer is referenced anyway in the code at line 386 (of transport_srtp.c): srtp->peer_use = opt->use; This should probably directly reference the default "use" parameter if opt == NULL. Ruud Klaver AG Projects
NI
Nanang Izzuddin
Tue, Jan 20, 2009 11:11 AM

Hi,

Ah, sorry for this silly mistake (of mine :( ), ticket #698
(http://trac.pjsip.org/repos/ticket/698) should fix this. Thanks for
the report.

Regards,
nanang

On Tue, Dec 2, 2008 at 10:25 PM, Ruud Klaver ruud@ag-projects.com wrote:

Hi,

According to the documentation it should be possible to call
pjmedia_transport_srtp_create() with the "opt" argument set to NULL, it
should just use the default SRTP settings. However, this pointer is
referenced anyway in the code at line 386 (of transport_srtp.c):

srtp->peer_use = opt->use;

This should probably directly reference the default "use" parameter if opt
== NULL.

Ruud Klaver
AG Projects


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi, Ah, sorry for this silly mistake (of mine :( ), ticket #698 (http://trac.pjsip.org/repos/ticket/698) should fix this. Thanks for the report. Regards, nanang On Tue, Dec 2, 2008 at 10:25 PM, Ruud Klaver <ruud@ag-projects.com> wrote: > Hi, > > According to the documentation it should be possible to call > pjmedia_transport_srtp_create() with the "opt" argument set to NULL, it > should just use the default SRTP settings. However, this pointer is > referenced anyway in the code at line 386 (of transport_srtp.c): > > srtp->peer_use = opt->use; > > This should probably directly reference the default "use" parameter if opt > == NULL. > > Ruud Klaver > AG Projects > > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >
RK
Ruud Klaver
Fri, Jan 23, 2009 5:15 PM

Hi Nanang,

Not a big problem for me. Thanks for the fix. ;)

Ruud Klaver
AG Projects

On 20 Jan 2009, at 12:11, Nanang Izzuddin wrote:

Hi,

Ah, sorry for this silly mistake (of mine :( ), ticket #698
(http://trac.pjsip.org/repos/ticket/698) should fix this. Thanks for
the report.

Regards,
nanang

On Tue, Dec 2, 2008 at 10:25 PM, Ruud Klaver ruud@ag-projects.com
wrote:

Hi,

According to the documentation it should be possible to call
pjmedia_transport_srtp_create() with the "opt" argument set to
NULL, it
should just use the default SRTP settings. However, this pointer is
referenced anyway in the code at line 386 (of transport_srtp.c):

srtp->peer_use = opt->use;

This should probably directly reference the default "use" parameter
if opt
== NULL.

Ruud Klaver
AG Projects


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Nanang, Not a big problem for me. Thanks for the fix. ;) Ruud Klaver AG Projects On 20 Jan 2009, at 12:11, Nanang Izzuddin wrote: > Hi, > > Ah, sorry for this silly mistake (of mine :( ), ticket #698 > (http://trac.pjsip.org/repos/ticket/698) should fix this. Thanks for > the report. > > Regards, > nanang > > > On Tue, Dec 2, 2008 at 10:25 PM, Ruud Klaver <ruud@ag-projects.com> > wrote: >> Hi, >> >> According to the documentation it should be possible to call >> pjmedia_transport_srtp_create() with the "opt" argument set to >> NULL, it >> should just use the default SRTP settings. However, this pointer is >> referenced anyway in the code at line 386 (of transport_srtp.c): >> >> srtp->peer_use = opt->use; >> >> This should probably directly reference the default "use" parameter >> if opt >> == NULL. >> >> Ruud Klaver >> AG Projects >> >> >> >> _______________________________________________ >> Visit our blog: http://blog.pjsip.org >> >> pjsip mailing list >> pjsip@lists.pjsip.org >> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >>