maildev@lists.thunderbird.net

Thunderbird email developers

View all threads

Re: [Maildev] Add-ons in TB 62 and beyond

PK
Philipp Kewisch
Wed, Jul 25, 2018 6:59 PM

On 25. Jul 2018, at 8:40 PM, Onno Ekker o.e.ekker@gmail.com wrote:

I didn't see any reply to my queries...

Using the latest daily I still see this warning on all installed
add-ons, even on Lightning: Lightning could not be verified for use in
Daily. Proceed with caution. I'll repeat my previous questions, in order
to ease replying to this message:

  • Is this a known issue?
  • Is it because the add-on isn't signed?
  • Will the add-ons on atn be signed by Thunderbird?
  • Do add-on authors need to sign their own add-on?

Signing is not being considered for Thunderbird at the moment.

I have added a manifest.json file to my bootstrapped add-on with
"legacy": true and I don't see any errors, but the add-on doesn't do
anything. The debug statements from my bootstrap.json don't display
anything on the console. * Should this work?

legacy: true works with legacy add-ons, not bootstrapped add-ons. We can consider adding support for these as well.

Also it seems that addons.thunderbird.net still returns an RDF-document
on an update ping, because I get a warning for an installed add-on, that
that format won't be supported for long anymore.

  • Is this intentional?
  • Maybe to help people using old, unsupported versions of Thunderbird to
    upgrade their add-ons??

This feature may not have been picked up from upstream.

Onno

On 7/17/2018 9:25 PM, Onno Ekker wrote:
Hi,

I get a warning on all add-ons in TB62, that they cannot be verified
by Daily. I get this even on language packs. It is possible to enable
the add-on.

I assume this is, because the add-ons on addons.thunderbird.net aren't
signed, but I'm not sure of this.

Is this a known issue? Is it indeed because of the signature? Will the
add-ons be signed by Thunderbird? Do add-on authors need to sign their
own add-on?

Onno

On 7/17/2018 8:26 PM, Jörg Knobloch wrote:
First draft: https://wiki.mozilla.org/Thunderbird/Add-ons_Guide_62

Jörg.

> On 25. Jul 2018, at 8:40 PM, Onno Ekker <o.e.ekker@gmail.com> wrote: > > I didn't see any reply to my queries... > > Using the latest daily I still see this warning on all installed > add-ons, even on Lightning: Lightning could not be verified for use in > Daily. Proceed with caution. I'll repeat my previous questions, in order > to ease replying to this message: > * Is this a known issue? > * Is it because the add-on isn't signed? > * Will the add-ons on atn be signed by Thunderbird? > * Do add-on authors need to sign their own add-on? Signing is not being considered for Thunderbird at the moment. > > I have added a manifest.json file to my bootstrapped add-on with > "legacy": true and I don't see any errors, but the add-on doesn't do > anything. The debug statements from my bootstrap.json don't display > anything on the console. * Should this work? legacy: true works with legacy add-ons, not bootstrapped add-ons. We can consider adding support for these as well. > > Also it seems that addons.thunderbird.net still returns an RDF-document > on an update ping, because I get a warning for an installed add-on, that > that format won't be supported for long anymore. > * Is this intentional? > * Maybe to help people using old, unsupported versions of Thunderbird to > upgrade their add-ons?? This feature may not have been picked up from upstream. > > Onno > >> On 7/17/2018 9:25 PM, Onno Ekker wrote: >> Hi, >> >> I get a warning on all add-ons in TB62, that they cannot be verified >> by Daily. I get this even on language packs. It is possible to enable >> the add-on. >> >> I assume this is, because the add-ons on addons.thunderbird.net aren't >> signed, but I'm not sure of this. >> >> Is this a known issue? Is it indeed because of the signature? Will the >> add-ons be signed by Thunderbird? Do add-on authors need to sign their >> own add-on? >> >> Onno >> >> >>> On 7/17/2018 8:26 PM, Jörg Knobloch wrote: >>> First draft: https://wiki.mozilla.org/Thunderbird/Add-ons_Guide_62 >>> >>> Jörg. >>> > > > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net
AH
Andrei Hajdukewycz
Thu, Jul 26, 2018 5:31 PM

On 2018-07-25 11:59 a.m., Philipp Kewisch wrote:

Also it seems that addons.thunderbird.net still returns an RDF-document
on an update ping, because I get a warning for an installed add-on, that
that format won't be supported for long anymore.

  • Is this intentional?
  • Maybe to help people using old, unsupported versions of Thunderbird to
    upgrade their add-ons??

This feature may not have been picked up from upstream.

addons-server doesn't support the use of json manifests for anything
other than Firefox, see
https://github.com/mozilla/addons-server/commit/131c8f22db98c6a09784202fc43b8c3cbb536025#diff-10cd395cf71c18328c863c08e78f3fd0
because it didn't work in Thunderbird 52.*

I'm assuming it does work in TB60 ESR?

On 2018-07-25 11:59 a.m., Philipp Kewisch wrote: >> Also it seems that addons.thunderbird.net still returns an RDF-document >> on an update ping, because I get a warning for an installed add-on, that >> that format won't be supported for long anymore. >> * Is this intentional? >> * Maybe to help people using old, unsupported versions of Thunderbird to >> upgrade their add-ons?? > This feature may not have been picked up from upstream. addons-server doesn't support the use of json manifests for anything other than Firefox, see https://github.com/mozilla/addons-server/commit/131c8f22db98c6a09784202fc43b8c3cbb536025#diff-10cd395cf71c18328c863c08e78f3fd0 because it didn't work in Thunderbird 52.* I'm assuming it does work in TB60 ESR?
AH
Andrei Hajdukewycz
Thu, Jul 26, 2018 8:03 PM

On 2018-07-26 10:31 a.m., Andrei Hajdukewycz wrote:

On 2018-07-25 11:59 a.m., Philipp Kewisch wrote:

Also it seems that addons.thunderbird.net still returns an RDF-document
on an update ping, because I get a warning for an installed add-on,
that
that format won't be supported for long anymore.

  • Is this intentional?
  • Maybe to help people using old, unsupported versions of
    Thunderbird to
    upgrade their add-ons??

This feature may not have been picked up from upstream.

addons-server doesn't support the use of json manifests for anything
other than Firefox, see
https://github.com/mozilla/addons-server/commit/131c8f22db98c6a09784202fc43b8c3cbb536025#diff-10cd395cf71c18328c863c08e78f3fd0
because it didn't work in Thunderbird 52.*

I'm assuming it does work in TB60 ESR?

OK, after asking jorgk about this on IRC it seems TB60 ESR doesn't
support manifest.json, which means that I'm going to have to change the
code to carve out a user-agent based exception for TB62+ only, I guess.
Unfortunate.

I've filed https://github.com/thundernest/addons-server/issues/12.

On 2018-07-26 10:31 a.m., Andrei Hajdukewycz wrote: > On 2018-07-25 11:59 a.m., Philipp Kewisch wrote: >>> Also it seems that addons.thunderbird.net still returns an RDF-document >>> on an update ping, because I get a warning for an installed add-on, >>> that >>> that format won't be supported for long anymore. >>> * Is this intentional? >>> * Maybe to help people using old, unsupported versions of >>> Thunderbird to >>> upgrade their add-ons?? >> This feature may not have been picked up from upstream. > addons-server doesn't support the use of json manifests for anything > other than Firefox, see > https://github.com/mozilla/addons-server/commit/131c8f22db98c6a09784202fc43b8c3cbb536025#diff-10cd395cf71c18328c863c08e78f3fd0 > because it didn't work in Thunderbird 52.* > > I'm assuming it does work in TB60 ESR? OK, after asking jorgk about this on IRC it seems TB60 ESR doesn't support manifest.json, which means that I'm going to have to change the code to carve out a user-agent based exception for TB62+ only, I guess. Unfortunate. I've filed https://github.com/thundernest/addons-server/issues/12.
T
Tito
Fri, Jul 27, 2018 7:29 AM

Hello,

I just read that Mozilla is intending to remove RSS from their code.
Question: How will that affect TB?

https://bugzilla.mozilla.org/show_bug.cgi?id=1477667

https://docs.google.com/document/d/1aIMPZVy33mn34pXBUETk4lt_NrJXupcMilTPFFVpmnI/edit

Tito

Hello, I just read that Mozilla is intending to remove RSS from their code. Question: How will that affect TB? https://bugzilla.mozilla.org/show_bug.cgi?id=1477667 https://docs.google.com/document/d/1aIMPZVy33mn34pXBUETk4lt_NrJXupcMilTPFFVpmnI/edit Tito
MM
Magnus Melin
Mon, Jul 30, 2018 6:53 AM

Thunderbird never used the Firefox RSS code, but has its own implementation.
So it doesn't really affect Thunderbird.

 -Magnus

On 27-07-2018 10:29, Tito wrote:

Thunderbird never used the Firefox RSS code, but has its own implementation. So it doesn't really affect Thunderbird.  -Magnus On 27-07-2018 10:29, Tito wrote: > Hello, > > I just read that Mozilla is intending to remove RSS from their code. > Question: How will that affect TB? > > https://bugzilla.mozilla.org/show_bug.cgi?id=1477667 > > https://docs.google.com/document/d/1aIMPZVy33mn34pXBUETk4lt_NrJXupcMilTPFFVpmnI/edit > > > > Tito > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net