I obviously have some stupid syntax error that I can't figure out.  I suspect
that I need to do something for my if statement that I haven't

I've looked at the manual and my module, if, and for statements look (to me)
conformant.  But obviously I've missed something.  The line "angle = " is
flagged as being bad, but if I move it above the if statement (or remove the
if statement) it goes past that and then has an issue with inside the for
loop.

What am I doing wrong?

module rfsphere(counter,geometry,growth,xoffset,yoffset,size)
{
if(counter>0)
{
angle = (360/geometry);
ratio = (1 / (geometry / 2));
newcounter = counter - 1;
newgeometry = geometry + growth;
newsize = size * ratio;
for(i=[1:1:geometry])
{
xoffset = xoffset + (size * sin(anglei);
yoffset = yoffset + (size * cos(anglei);
translate([x,y,0]) {
sphere(newsize, $fn=100);
}
rfsphere(newcounter, newgeometry, growth, xoffset, yoffset, newsize);
}
}

--
View this message in context: http://forum.openscad.org/a-stupid-syntax-error-I-can-t-see-tp18036.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

The two lines with offset in them, xoffset and yoffset are missing trailing )
and the entire module needs a closing }

I did not test any other aspect other than to identify the syntax problems.

--
View this message in context: http://forum.openscad.org/a-stupid-syntax-error-I-can-t-see-tp18036p18038.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

Thanks for picking up those errors. I did not see the missing closing brace
or the missing parens.  But even after those are fixed, it oddly still
complains that there is a syntax error on the first assignment.  Is
something wrong with my "if" syntax?

it still highlights the whitespace character just after "angle =" and says
there is a syntax error on that line

module rfsphere(counter,geometry,growth,xoffset,yoffset,size)
{
if(counter>0)
{
angle = (360/geometry);
ratio = (1 / (geometry / 2));
newcounter = counter - 1;
newgeometry = geometry + growth;
newsize = size * ratio;
for(i=[1:1:geometry])
{
xoffset = xoffset + (size * sin(anglei));
yoffset = yoffset + (size * cos(anglei));
translate([x,y,0])
{
sphere(newsize, $fn=100);
}
rfsphere(newcounter, newgeometry, growth, xoffset, yoffset, newsize);
}
}
}

--
View this message in context: http://forum.openscad.org/a-stupid-syntax-error-I-can-t-see-tp18036p18072.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

I don't get a syntax error or any error message when F5 on the module alone.
Calling the module from outside results in an error, because your module
contains a call to your module. Should the code you've presented be
separated into two distinct segments?

--
View this message in context: http://forum.openscad.org/a-stupid-syntax-error-I-can-t-see-tp18036p18073.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

You and Drew pointed out that I'd meant xoffset and written x.

I was just showing the recursive part of my module.

Even after correcting x by chaning it to xoffset (and the same for y) I
still get a syntax error on the first assignment (which confuses me).

I'll put all the code here (recursive and non recursive parts), it still
flags the "angle =" line as being bad.  Which makes me wonder if my if or
module syntax is wrong.

module rfsphere(counter,geometry,growth,xoffset,yoffset,size)
{
if(counter>0)
{
angle = (360/geometry);
ratio = (1 / (geometry / 2));
newcounter = counter - 1;
newgeometry = geometry + growth;
newsize = size * ratio;
for(i=[1:1:geometry])
{
xoffset = xoffset + (size * sin(anglei));
yoffset = yoffset + (size * cos(anglei));
translate([xoffset,yoffset,0])
{
sphere(newsize, $fn=100);
}
rfsphere(newcounter, newgeometry, growth, xoffset, yoffset, newsize);
}
}
}

module fsphere(counter,geometry,growth,size){
sphere(size, $fn=100);
counter = counter - 1;
newsize = (1 / (geometry/2))*size;

angle = 360/geometry;
ratio = 1 / (geometry / 2);
newgeometry = geomertry + growth;
for(i=steps(1,1,geometry)) {
x = size * sin(anglei);
y = size * cos(anglei);
translate([x,y,0]) {
sphere(sizescale, $fn=100);
}
rfsphere(counter, newgeometry, growth, x, y, sizescale);
}
}

fsphere(4,3,2,100);

--
View this message in context: http://forum.openscad.org/a-stupid-syntax-error-I-can-t-see-tp18036p18075.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

You can't do assignments inside a conditional in openscad. It's part of the
fact that openscad variables aren't really variables. You're also changing
the values of variables later, which isn't allowed either.

You can do conditional variable assignment using the ternary operator, but
for this purpose, it doesn't look like it's necessary, just set your
variables before going into the if statement. Getting rid of the
reassignments will be a little more complicated.

From: DanS tabbydan@gmail.com tabbydan@gmail.com
Reply: OpenSCAD general discussion discuss@lists.openscad.org
discuss@lists.openscad.org
Date: August 6, 2016 at 15:11:04
To: discuss@lists.openscad.org discuss@lists.openscad.org
discuss@lists.openscad.org
Subject:  Re: [OpenSCAD] a stupid syntax error I can't see

You and Drew pointed out that I'd meant xoffset and written x.

I was just showing the recursive part of my module.

Even after correcting x by chaning it to xoffset (and the same for y) I
still get a syntax error on the first assignment (which confuses me).

I'll put all the code here (recursive and non recursive parts), it still
flags the "angle =" line as being bad. Which makes me wonder if my if or
module syntax is wrong.

module rfsphere(counter,geometry,growth,xoffset,yoffset,size)
{
if(counter>0)
{
angle = (360/geometry);
ratio = (1 / (geometry / 2));
newcounter = counter - 1;
newgeometry = geometry + growth;
newsize = size * ratio;
for(i=[1:1:geometry])
{
xoffset = xoffset + (size * sin(anglei));
yoffset = yoffset + (size * cos(anglei));
translate([xoffset,yoffset,0])
{
sphere(newsize, $fn=100);
}
rfsphere(newcounter, newgeometry, growth, xoffset, yoffset, newsize);
}
}
}

module fsphere(counter,geometry,growth,size){
sphere(size, $fn=100);
counter = counter - 1;
newsize = (1 / (geometry/2))*size;

angle = 360/geometry;
ratio = 1 / (geometry / 2);
newgeometry = geomertry + growth;
for(i=steps(1,1,geometry)) {
x = size * sin(anglei);
y = size * cos(anglei);
translate([x,y,0]) {
sphere(sizescale, $fn=100);
}
rfsphere(counter, newgeometry, growth, x, y, sizescale);
}
}

fsphere(4,3,2,100);

--
View this message in context:
http://forum.openscad.org/a-stupid-syntax-error-I-can-t-see-tp18036p18075.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

OpenSCAD mailing list
Discuss@lists.openscad.org
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

Thanks, that gets rid of those syntax errors and I'll try to remember no
assignments inside if statements.

--
View this message in context: http://forum.openscad.org/a-stupid-syntax-error-I-can-t-see-tp18036p18077.html
Sent from the OpenSCAD mailing list archive at Nabble.com.