Empathy List Archives

TP

Tom Prince

Sat, Jul 22, 2017 6:29 PM

I have enable automatic commenting on and closing of bugs for commits
pushed to comm-central (https://github.com/glandium/pulsebot/pull/16). The
closing will be skipped if the bug has the keyword leave-open.

The automation doesn't currently set the target-milestone, but I intend to
implement that as well. (
https://bugzilla.mozilla.org/show_bug.cgi?id=1383442)

-- Tom

I have enable automatic commenting on and closing of bugs for commits pushed to comm-central (https://github.com/glandium/pulsebot/pull/16). The closing will be skipped if the bug has the keyword `leave-open`. The automation doesn't currently set the target-milestone, but I intend to implement that as well. ( https://bugzilla.mozilla.org/show_bug.cgi?id=1383442) -- Tom

BB

Ben Bucksch

Sat, Jul 22, 2017 9:18 PM

The comments with the commit URL are great, and surely useful. Thanks for that.

I would prefer no automatic closing, though.
A) because not all patches did bis completely, and it's easy to forget the leave-open.
B) more importantly, because the author should make an explicit statement what he did, a sort of summary of the fix, and why he thinks that this fixes the bug.

Both arguments apply only to complex bugs that received attention.

Generally, i would prefer we discuss such changes to the process here first.

Ben

Am 22. Juli 2017 20:29:01 MESZ schrieb Tom Prince via Maildev maildev@lists.thunderbird.net:

I have enable automatic commenting on and closing of bugs for commits
pushed to comm-central (https://github.com/glandium/pulsebot/pull/16).
The
closing will be skipped if the bug has the keyword leave-open.

The automation doesn't currently set the target-milestone, but I intend
to
implement that as well. (
https://bugzilla.mozilla.org/show_bug.cgi?id=1383442)

-- Tom

--
This email was sent from my phone. Please excuse the brevity

The comments with the commit URL are great, and surely useful. Thanks for that. I would prefer no automatic closing, though. A) because not all patches did bis completely, and it's easy to forget the leave-open. B) more importantly, because the author should make an explicit statement what he did, a sort of summary of the fix, and why he thinks that this fixes the bug. Both arguments apply only to complex bugs that received attention. Generally, i would prefer we discuss such changes to the process here first. Ben Am 22. Juli 2017 20:29:01 MESZ schrieb Tom Prince via Maildev <maildev@lists.thunderbird.net>: >I have enable automatic commenting on and closing of bugs for commits >pushed to comm-central (https://github.com/glandium/pulsebot/pull/16). >The >closing will be skipped if the bug has the keyword `leave-open`. > >The automation doesn't currently set the target-milestone, but I intend >to >implement that as well. ( >https://bugzilla.mozilla.org/show_bug.cgi?id=1383442) > >-- Tom -- This email was sent from my phone. Please excuse the brevity

JK

Jörg Knobloch

Sat, Jul 22, 2017 9:50 PM

On 22/07/2017 23:18, Ben Bucksch via Maildev wrote:

I would prefer no automatic closing, though.

Well, the action to land a bug has four steps, I count them, so I don't forget:

remove checkin-needed (if present)
set the target milestone
paste the changeset(s) into a comment
mark the bug fixed.

Either we have automation to do those four things or else this is not useful since I'll have to revisit the bug anyway. The ratio of "leave-open" bugs is really minimal.

It gets tricky with calendar bugs since the have different milestones, like (n+2)/10, so 52->5.4.

Jörg.

TP

Tom Prince

Mon, Jul 24, 2017 5:09 PM

Generally, i would prefer we discuss such changes to the process here

first.

Given that there is little risk (some bugs might be inadvertently closed,
but the people working on them are likely to notice), and it is an easy to
change to back out, it seemed simpler to just enable it.

-- Tom

> Generally, i would prefer we discuss such changes to the process here first. Given that there is little risk (some bugs might be inadvertently closed, but the people working on them are likely to notice), and it is an easy to change to back out, it seemed simpler to just enable it. -- Tom

WM

Wayne Mery

Mon, Jul 24, 2017 5:47 PM

On 7/22/2017 5:50 PM, Jörg Knobloch via Maildev wrote:

On 22/07/2017 23:18, Ben Bucksch via Maildev wrote:

I would prefer no automatic closing, though.

Well, the action to land a bug has four steps, I count them, so I don't
forget:

remove checkin-needed (if present)
set the target milestone
paste the changeset(s) into a comment
mark the bug fixed.

Either we have automation to do those four things or else this is not
useful since I'll have to revisit the bug anyway. The ratio of
"leave-open" bugs is really minimal.

It gets tricky with calendar bugs since the have different milestones,
like (n+2)/10, so 52->5.4.

Jörg.

I'd like the fact that there might be less bugmail :)

On 7/22/2017 5:50 PM, Jörg Knobloch via Maildev wrote: > On 22/07/2017 23:18, Ben Bucksch via Maildev wrote: >> I would prefer no automatic closing, though. > > Well, the action to land a bug has four steps, I count them, so I don't > forget: > > 1. remove checkin-needed (if present) > 2. set the target milestone > 3. paste the changeset(s) into a comment > 4. mark the bug fixed. > > Either we have automation to do those four things or else this is not > useful since I'll have to revisit the bug anyway. The ratio of > "leave-open" bugs is really minimal. > > It gets tricky with calendar bugs since the have different milestones, > like (n+2)/10, so 52->5.4. > > Jörg. I'd like the fact that there might be less bugmail :)

JK

Jörg Knobloch

Mon, Jul 24, 2017 6:14 PM

On 24/07/2017 19:47, Wayne Mery via Maildev wrote:

I'd like the fact that there might be less bugmail

Not less bugmail: whether the sheriff or the bot create the comment,
it's still a comment. Currently it creates more bugmail since I need to
set the target milestone separately creating another message.

Jörg.

On 24/07/2017 19:47, Wayne Mery via Maildev wrote: > I'd like the fact that there might be less bugmail Not less bugmail: whether the sheriff or the bot create the comment, it's still a comment. Currently it creates more bugmail since I need to set the target milestone separately creating another message. Jörg.

MM

Magnus Melin

Mon, Jul 24, 2017 10:18 PM

Well Firefox has been auto closing for years (yes, under somewhat
different circumstances). In general the goal should be one landing per
bug, so auto closing is not that controversial in practice, IMHO.

For #B, that info is in the bug already. Nobody puts that in the closing
comment.

-Magnus

On 7/23/17 12:18 AM, Ben Bucksch via Maildev wrote:

I would prefer no automatic closing, though.
A) because not all patches did bis completely, and it's easy to forget
the leave-open.
B) more importantly, because the author should make an explicit
statement what he did, a sort of summary of the fix, and why he thinks
that this fixes the bug.

Well Firefox has been auto closing for years (yes, under somewhat different circumstances). In general the goal should be one landing per bug, so auto closing is not that controversial in practice, IMHO. For #B, that info is in the bug already. Nobody puts that in the closing comment. -Magnus On 7/23/17 12:18 AM, Ben Bucksch via Maildev wrote: > I would prefer no automatic closing, though. > A) because not all patches did bis completely, and it's easy to forget > the leave-open. > B) more importantly, because the author should make an explicit > statement what he did, a sort of summary of the fix, and why he thinks > that this fixes the bug.

BB

Ben Bucksch

Mon, Jul 24, 2017 11:50 PM

Seems like at least Jörg and Magnus are in favor, so nevermind my objection.

Am 22. Juli 2017 23:50:37 MESZ schrieb "Jörg Knobloch via Maildev" maildev@lists.thunderbird.net:

Maildev mailing list
Maildev@lists.thunderbird.net
http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net

--
This email was sent from my phone. Please excuse the brevity

Seems like at least Jörg and Magnus are in favor, so nevermind my objection. Am 22. Juli 2017 23:50:37 MESZ schrieb "Jörg Knobloch via Maildev" <maildev@lists.thunderbird.net>: >_______________________________________________ >Maildev mailing list >Maildev@lists.thunderbird.net >http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net -- This email was sent from my phone. Please excuse the brevity

maildev@lists.thunderbird.net

Bugzilla Automation