On 18/06/2018 10:44, Philipp Kewisch wrote: > Spinning the event loop to wait for an async function to complete > breaks the intended workflow of JavaScript and isn't something that > shouldn't be used in production. I think the grammar derailed here a little ;-) Maybe: Spinning the event loop to wait for an async function *completely* breaks the intended workflow of JavaScript and *is* something that shouldn't be used in production. As I said, it *is* used in production here: https://dxr.mozilla.org/comm-beta/source/mail/base/content/mailWindowOverlay.js#3764 Should we replace that? Jörg.

The complete part is correct as is, "shouldn't" should be "should". But in short, yes, please avoid using this technique. Philipp > On 18. Jun 2018, at 10:53 AM, Jörg Knobloch <jorgk@jorgk.com> wrote: > >> On 18/06/2018 10:44, Philipp Kewisch wrote: >> Spinning the event loop to wait for an async function to complete breaks the intended workflow of JavaScript and isn't something that shouldn't be used in production. > > I think the grammar derailed here a little ;-) Maybe: > > Spinning the event loop to wait for an async function *completely* breaks the intended workflow of JavaScript and *is* something that shouldn't be used in production. > > As I said, it *is* used in production here: > > https://dxr.mozilla.org/comm-beta/source/mail/base/content/mailWindowOverlay.js#3764 > > Should we replace that? > > Jörg. > > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net