maildev@lists.thunderbird.net

Thunderbird email developers

View all threads

Re: [Maildev] Thunderbird Nightly broken recently (and fixed) - Resending, this time to Tom who is not on the list

JK
Jonathan Kamens
Sat, Aug 3, 2019 1:55 PM

(Moving discussion to maildev from drivers as requested by Jörg.)

  1. The sugar.js module in my add-on doesn't have the word "eval"
    anywhere in it, so I don't know how to identify where eval is ostensibly
    being called so that I can fix it.

  2. SugarJS is a third-party library, and a pretty complex one at that,
    so I changing it to eliminate the use of eval is not something that can
    necessarily be done "in short." It might be quite complicated to do, and
    it's not my code, so it's something I'd really prefer not to dive into.

  3. Is Thunderbird going to turn crash-on-eval back on any time soon, or
    isn't it?

  jik

On 8/3/19 1:50 AM, Jörg Knobloch wrote:

On 03 Aug 2019 05:34, Jonathan Kamens wrote:

I'm really not sure what "in the System Principal context" means, so
even if I did need to do something about this I don't really have any
idea what to do.

Hi Jonathan, in short, you need to eliminate use of "eval()", see
https://bugzilla.mozilla.org/show_bug.cgi?id=1473549. Jörg.

P.S.: Let's move the discussion to MailDev.

(Moving discussion to maildev from drivers as requested by Jörg.) 1) The sugar.js module in my add-on doesn't have the word "eval" anywhere in it, so I don't know how to identify where eval is ostensibly being called so that I can fix it. 2) SugarJS is a third-party library, and a pretty complex one at that, so I changing it to eliminate the use of eval is not something that can necessarily be done "in short." It might be quite complicated to do, and it's not my code, so it's something I'd really prefer not to dive into. 3) Is Thunderbird going to turn crash-on-eval back on any time soon, or isn't it?   jik On 8/3/19 1:50 AM, Jörg Knobloch wrote: > On 03 Aug 2019 05:34, Jonathan Kamens wrote: >> I'm really not sure what "in the System Principal context" means, so >> even if I did need to do something about this I don't really have any >> idea what to do. > > Hi Jonathan, in short, you need to eliminate use of "eval()", see > https://bugzilla.mozilla.org/show_bug.cgi?id=1473549. Jörg. > > P.S.: Let's move the discussion to MailDev. >