amr_helper.h: Frame length of AMR-WB bitrate 14.25

ZT
Zoltan.Toth.ext@rohde-schwarz.com
Mon, May 26, 2014 1:33 PM

Hello,

I found that the frame length definition for AMR-WB bitrate 12.45 is
incorrect. This bitrate has a frame length of 285 bits, which corresponds
to 36 bytes.
However, pjmedia_codec_amrwb_framelen[3] is set to 37. This makes the
buffer availability check fail in pjmeda_codec_amr_pack() if the caller
does not provide an extra byte in the payload.

Regards
Zoltan

Hello, I found that the frame length definition for AMR-WB bitrate 12.45 is incorrect. This bitrate has a frame length of 285 bits, which corresponds to 36 bytes. However, pjmedia_codec_amrwb_framelen[3] is set to 37. This makes the buffer availability check fail in pjmeda_codec_amr_pack() if the caller does not provide an extra byte in the payload. Regards Zoltan
M
Ming
Wed, May 28, 2014 6:28 AM

Hi Zoltan,

You are right. But unfortunately, there doesn't seem to be an easy way to
fix it without affecting backward compatibility. So what currently happens
when the framelen is set to 37. Does the client fail with assertion or only
one-way audio?

Regards,
Ming

On Mon, May 26, 2014 at 9:33 PM, Zoltan.Toth.ext@rohde-schwarz.com wrote:

Hello,

I found that the frame length definition for AMR-WB bitrate 12.45 is
incorrect. This bitrate has a frame length of 285 bits, which corresponds
to 36 bytes.
However, pjmedia_codec_amrwb_framelen[3] is set to 37. This makes the
buffer availability check fail in pjmeda_codec_amr_pack() if the caller
does not provide an extra byte in the payload.

Regards
Zoltan


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Zoltan, You are right. But unfortunately, there doesn't seem to be an easy way to fix it without affecting backward compatibility. So what currently happens when the framelen is set to 37. Does the client fail with assertion or only one-way audio? Regards, Ming On Mon, May 26, 2014 at 9:33 PM, <Zoltan.Toth.ext@rohde-schwarz.com> wrote: > Hello, > > I found that the frame length definition for AMR-WB bitrate 12.45 is > incorrect. This bitrate has a frame length of 285 bits, which corresponds > to 36 bytes. > However, pjmedia_codec_amrwb_framelen[3] is set to 37. This makes the > buffer availability check fail in pjmeda_codec_amr_pack() if the caller > does not provide an extra byte in the payload. > > Regards > Zoltan > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >